@nromancarcamo
Love the tips, I feel 100% relatable due to I have done some of the things you said, but I learn somethings as well, the difference I see is that you have already like a framework in your head, maybe because of your vast experience which is something really good. 👍 You gained a new subscriber.
@brooklynwright7109
I have an upcoming interview focused on code review and this video was just so good. I'll definitely try to apply your tips and approach also at work. Thanks!
@josefernandoc.s.9752
Great video! I use your videos to practice English, and your tips are so easy to learn. Thanks, bro!
@dimaorols8143
I'd be straight to be point with things I dislike, and have an open mind. I'd ask questions when I wouldn't understand the intended output for project N, but not to say that I found something wrong with the code. Had a co-worker leaving such remarks: "Don't you think this would've been better?", "Why did you do it this way instead if using our in built code?" That's a bad approach. I rather guide the developer and explain within reason why something might be out of bounds and provide examples.
@dashengovender766
Great advice, tips and rundown Cody!
@jackli1924
Great explaination! Thank you a ton!
@sk8sbest
Would love a video on unit tests!
@MaxLambrecht
Great video! I had a question about the part where you mention DMing the author to discuss issues in a PR. Doesn’t that go against the purpose of pull requests—keeping discussions transparent, collaborative, and documented? I usually try to keep all feedback within the PR itself for that reason. Curious to hear your take on this!
@robertstitt4004
Greetings! I'm also a software engineer here in Chicago! Love you videos!
@Nei月牙天衝-y7u
Amazing video. You just gained another subscriber.
@raw_tech_with_tom
Going to rewatch this
@gunedaa9621
This was super helpful as a junior software engineer who hasn't delivered a proper code review before, I especially like that you also take the time to compliment when you see a good piece of code. Do you have any recommendations for code review interviews? I've applied to a job and passed the live coding session and next is to do a code review interview which I haven't done before for any of my previous job applications. Would be super helpful to get your insights :)
@saquibsiddique2641
Great job 👍 Really helpful 🙂
@daniel_goncalves
Great vídeo. Congrtulations. Im tring to imolements pode Review on my team, and I have more operationals doubts. How are the branchs? Dont u have problems of mergin? Thanks
@akashgeorge5433
i would like to know how to write good unit tests
@devvilboyy676767
Can you give us an example of things you pass or let slide when reviewing and vice versa things that absolutely need to be changed
@shyamagrawal6161
Thanks for valuable stuff
@mani653
being Senior engineer ,how do we manage our own work along with the PR review , which is quite challenging , which leads to poor code quality.
@JoePrivett-cr5np
The percentage of reviews that you approve are the opposite to me - I usually approve about 20% of the time, i.e. without the need for a comment or change.
@CodyEngelCodes